Open
Conversation
uses if-then-else requires json schema 2019-09 or newer so we can use unevaluatedProperties
add polymorphic type
b11a049 to
d17bb6c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Log
Note this bumps the json schema version to the latest (2020). This will break the app package because fastify by default uses the older v7 json schema draft (in part because it's faster). That can be worked around as follows (this allows turns off type coercion for body elements because they should not need coercion, they should come with the correct types... but maybe some clients have been getting away with sending strings instead of the correct type so it'd be more backwards compatible to leave type coercion on for body too):
Checklist